Bug 38389 - [Qt] Update the Symbian version for the user agent
Summary: [Qt] Update the Symbian version for the user agent
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 35784
  Show dependency treegraph
 
Reported: 2010-04-30 07:41 PDT by Benjamin Poulain
Modified: 2010-05-30 14:50 PDT (History)
13 users (show)

See Also:


Attachments
Patch with SymbianOS^2 to SymbianOS^4 (1.34 KB, patch)
2010-05-03 04:35 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff
Alternative: use SymbianOS/XX for the old scheme, and Symbian^X for the new scheme (2.15 KB, patch)
2010-05-03 04:36 PDT, Benjamin Poulain
laszlo.gombos: review-
Details | Formatted Diff | Diff
Symbian (and Maemo5) UA fixes (4.73 KB, patch)
2010-05-19 19:10 PDT, Laszlo Gombos
no flags Details | Formatted Diff | Diff
patch for 4.6 (untested) (1009 bytes, patch)
2010-05-19 20:18 PDT, Laszlo Gombos
no flags Details | Formatted Diff | Diff
patch for 4.6 v2 - add "Mobile" to the UA string as well (1.33 KB, patch)
2010-05-19 20:42 PDT, Laszlo Gombos
no flags Details | Formatted Diff | Diff
patch for 4.6 v3 (created with git diff) (3.01 KB, patch)
2010-05-28 21:27 PDT, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2010-04-30 07:41:58 PDT
The current user agent string does not take into account the new versions of Symbian:
Symbian^2, Symbian^3 and Symbian^4.
Comment 1 Benjamin Poulain 2010-05-03 04:35:09 PDT
Created attachment 54914 [details]
Patch with SymbianOS^2 to SymbianOS^4
Comment 2 Benjamin Poulain 2010-05-03 04:36:19 PDT
Created attachment 54915 [details]
Alternative: use SymbianOS/XX for the old scheme, and Symbian^X for the new scheme
Comment 3 Benjamin Poulain 2010-05-03 04:38:20 PDT
Note that even if the second patch is preferred, the string SymbianOS will still be in the user agent because the string currently use "SymbianOS" as platform.
Comment 4 Laszlo Gombos 2010-05-03 06:08:05 PDT
As SV_SF_1 is the same than SV_9_4, we decide if it make sense to change 'SymbianOS/9.4" to "Symbian^1". At the moment it is safer to keep it as it is, but I'd like to at least consider it.
Comment 5 Benjamin Poulain 2010-05-03 06:12:46 PDT
(In reply to comment #4)
> As SV_SF_1 is the same than SV_9_4, we decide if it make sense to change
> 'SymbianOS/9.4" to "Symbian^1". At the moment it is safer to keep it as it is,
> but I'd like to at least consider it.

Is there any Symbian^1 device?
I thought it was S60v5 re-branded for historic reason.
Comment 6 Jesus Sanchez-Palencia 2010-05-06 14:06:33 PDT
I don't think this is QuickTime related; changing to Qt. ;-)
Comment 7 Kenneth Rohde Christiansen 2010-05-07 06:10:20 PDT
(In reply to comment #4)
> As SV_SF_1 is the same than SV_9_4, we decide if it make sense to change
> 'SymbianOS/9.4" to "Symbian^1". At the moment it is safer to keep it as it is,
> but I'd like to at least consider it.

Why safer? :-) If people are testing for SymbianOS today, it would be nice if their tests fail so that we don't get the somewhat crappy Symbian optimized pages.
Comment 8 Kenneth Rohde Christiansen 2010-05-07 06:11:18 PDT
(In reply to comment #5)
> (In reply to comment #4)
> > As SV_SF_1 is the same than SV_9_4, we decide if it make sense to change
> > 'SymbianOS/9.4" to "Symbian^1". At the moment it is safer to keep it as it is,
> > but I'd like to at least consider it.
> 
> Is there any Symbian^1 device?
> I thought it was S60v5 re-branded for historic reason.

Exactly, ^1 is rebranding, ^2 is opensource version of ^1, ...
Comment 9 Kenneth Rohde Christiansen 2010-05-07 06:26:31 PDT
Comment on attachment 54915 [details]
Alternative: use SymbianOS/XX for the old scheme, and Symbian^X for the new scheme

So now we have:

SymbianOS/XX
Symbian^X
Symbian/XX (Unknown)

Will the Symbian^2 etc have subversions in the future? like Symbian^2/9.2 or anything like that?

How should we treat the unknown? I just using just Symbian or SymbianOS would be fine.
Comment 10 Benjamin Poulain 2010-05-07 06:34:32 PDT
(In reply to comment #9)
> Symbian/XX (Unknown)
> 
> How should we treat the unknown? I just using just Symbian or SymbianOS would
> be fine.

I kept the "/" because I don't know if Unknown can refer to and older Symbian, or a Symbian running on a non-Nokia phone.
Comment 11 Kenneth Rohde Christiansen 2010-05-07 06:39:34 PDT
(In reply to comment #10)
> (In reply to comment #9)
> > Symbian/XX (Unknown)
> > 
> > How should we treat the unknown? I just using just Symbian or SymbianOS would
> > be fine.
> 
> I kept the "/" because I don't know if Unknown can refer to and older Symbian,
> or a Symbian running on a non-Nokia phone.

I don't think anyone would actually look for "unknown" :-) I guess you handle what you can handle and then just use a fallback for the rest.

Maybe Laszlo has some insight, or Zalan?
Comment 12 Laszlo Gombos 2010-05-07 14:45:50 PDT
(In reply to comment #7)
> (In reply to comment #4)
> > As SV_SF_1 is the same than SV_9_4, we decide if it make sense to change
> > 'SymbianOS/9.4" to "Symbian^1". At the moment it is safer to keep it as it is,
> > but I'd like to at least consider it.
> 
> Why safer? :-) If people are testing for SymbianOS today, it would be nice if
> their tests fail so that we don't get the somewhat crappy Symbian optimized
> pages.

Yes, I had the same reasoning, but I have no hands on data if this is really the case.
Comment 13 Benjamin Poulain 2010-05-11 04:48:03 PDT
Comment on attachment 54915 [details]
Alternative: use SymbianOS/XX for the old scheme, and Symbian^X for the new scheme

Test Bugzilla
Comment 14 Benjamin Poulain 2010-05-11 04:48:25 PDT
Comment on attachment 54915 [details]
Alternative: use SymbianOS/XX for the old scheme, and Symbian^X for the new scheme

Restore flags
Comment 15 Laszlo Gombos 2010-05-12 07:35:38 PDT
Comment on attachment 54914 [details]
Patch with SymbianOS^2 to SymbianOS^4

Looks good to me, thanks. r+.
Comment 16 Laszlo Gombos 2010-05-12 07:38:02 PDT
Comment on attachment 54915 [details]
Alternative: use SymbianOS/XX for the old scheme, and Symbian^X for the new scheme

r- as we decided to go with the first patch only. 

If we find an actual (maybe top 100 or so) case where changing the SymbianOS make a difference, we should reconsider this approach.
Comment 17 WebKit Commit Bot 2010-05-14 01:33:08 PDT
Comment on attachment 54914 [details]
Patch with SymbianOS^2 to SymbianOS^4

Clearing flags on attachment: 54914

Committed r59451: <http://trac.webkit.org/changeset/59451>
Comment 18 WebKit Commit Bot 2010-05-14 01:33:15 PDT
All reviewed patches have been landed.  Closing bug.
Comment 19 Simon Hausmann 2010-05-14 01:47:04 PDT
Revision r59451 cherry-picked into qtwebkit-2.0 with commit 7eb1783afff639ecc1e0b57eb5f341171dd99afd
Comment 20 Laszlo Gombos 2010-05-19 17:20:51 PDT
Here is the latest proposal for the "final" UA string for N8. The closest QtWebKit can get to the following UA string the more likely we will avoid fragmentation between QtWebKit clients.

"Mozilla/5.0 (Symbian/3; U; NokiaN8-00; Profile/MIDP-2.1 Configuration/CLDC-1.1
en-US) AppleWebKit/532.4 (KHTML, like Gecko) QtLauncher/1.0 Mobile Safari/532.4
Comment 21 Laszlo Gombos 2010-05-19 18:29:12 PDT
Reopen to fix the UA for Symbian port of QtWebKit as suggested above and fix regression introduced by r58648.
Comment 22 Laszlo Gombos 2010-05-19 19:10:45 PDT
Created attachment 56547 [details]
Symbian (and Maemo5) UA fixes
Comment 23 Laszlo Gombos 2010-05-19 20:18:02 PDT
Created attachment 56550 [details]
patch for 4.6 (untested)
Comment 24 Laszlo Gombos 2010-05-19 20:20:19 PDT
Tested patch to fill out the model number and CLDC_MIDP version (e.g. "NokiaN8-00; Profile/MIDP-2.1 Configuration/CLDC-1.1") would be welcome - either using public Symbian APIs or perhaps QtMobility APIs (SysInfo?).
Comment 25 Laszlo Gombos 2010-05-19 20:42:33 PDT
Created attachment 56553 [details]
patch for 4.6 v2 - add "Mobile" to the UA string as well
Comment 26 Benjamin Poulain 2010-05-20 02:08:08 PDT
Do you really want SymbianOS/4 for Symbian^4? What happen if Symbian numbering goes to 9: Symbian^9 != SymbianOS/9.
Comment 27 Laszlo Gombos 2010-05-20 04:40:53 PDT
I think the attached patch makes the version "Symbian/4" and not "SymbianOS/4" for Symbian^4.

The idea is that we use "SymbianOS" for the "old" Symbian numbering and "only" "Symbian" for the "new" Symbian numbering.

I like this idea as it makes the UA overall shorter going forward - and at the same time it is clear which generation of version UA refers to.

This is also inline with the actual re-scoping of Symbian Foundation as Symbian now includes more SW components than just lower "OS level" pieces.
Comment 28 Benjamin Poulain 2010-05-20 04:46:00 PDT
(In reply to comment #27)
> I think the attached patch makes the version "Symbian/4" and not "SymbianOS/4" for Symbian^4.

You are right. I misunderstood the intent.
Comment 29 Kenneth Rohde Christiansen 2010-05-22 12:16:55 PDT
Comment on attachment 56547 [details]
Symbian (and Maemo5) UA fixes

Fine with me. Btw, should we change the Q_WS_MAEMO_5 test to MAEMO? is MAEMO still defined on Maemo 6 and beyond? We will also soon have to deal with MeeGo, but that is more complicated as MeeGo is not only for mobile devices.
Comment 30 WebKit Commit Bot 2010-05-23 01:42:40 PDT
Comment on attachment 56547 [details]
Symbian (and Maemo5) UA fixes

Clearing flags on attachment: 56547

Committed r60030: <http://trac.webkit.org/changeset/60030>
Comment 31 WebKit Commit Bot 2010-05-23 01:42:48 PDT
All reviewed patches have been landed.  Closing bug.
Comment 32 Simon Hausmann 2010-05-25 01:47:24 PDT
Revision r60030 cherry-picked into qtwebkit-2.0 with commit 815dbb2d4ab288a51e966fac798f852494bd8b5d
Comment 33 Laszlo Gombos 2010-05-28 21:27:17 PDT
Created attachment 57404 [details]
patch for 4.6 v3 (created with git diff)
Comment 34 Simon Hausmann 2010-05-30 14:50:36 PDT
(In reply to comment #33)
> Created an attachment (id=57404) [details]
> patch for 4.6 v3 (created with git diff)

Cherry-picked into qtwebkit-4.6 with commit 3bb0df4f00fa0b3ac3abc1b6fe508080fabdeaab