Bug 38444 - [Qt] GraphicsLayer caches directly composited images
Summary: [Qt] GraphicsLayer caches directly composited images
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks: 38744
  Show dependency treegraph
 
Reported: 2010-05-02 17:44 PDT by Noam Rosenthal
Modified: 2010-05-16 01:03 PDT (History)
6 users (show)

See Also:


Attachments
Only cache HTML content (1.43 KB, patch)
2010-05-02 17:47 PDT, Noam Rosenthal
kenneth: review+
kenneth: commit-queue-
Details | Formatted Diff | Diff
added comments per Kenneth's review (1.97 KB, patch)
2010-05-13 10:35 PDT, Noam Rosenthal
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Rosenthal 2010-05-02 17:44:08 PDT
it could be optimized to draw them directly.
Comment 1 Noam Rosenthal 2010-05-02 17:47:12 PDT
Created attachment 54894 [details]
Only cache HTML content
Comment 2 Eric Seidel (no email) 2010-05-02 18:24:24 PDT
Comment on attachment 54894 [details]
Only cache HTML content

Looks sane.  Do other ports have this optimization?
Comment 3 Noam Rosenthal 2010-05-02 18:30:42 PDT
Yes - that's what the direct-compositing API in GraphicsLayer.h is for. We've had this optimization in before, but I omitted it by mistake when I introduced another optimization
Comment 4 Kenneth Rohde Christiansen 2010-05-12 05:43:46 PDT
Comment on attachment 54894 [details]
Only cache HTML content

I think this deserves an explanation in the code. So please add a comment.
Comment 5 Noam Rosenthal 2010-05-13 10:35:53 PDT
Created attachment 55994 [details]
added comments per Kenneth's review
Comment 6 WebKit Commit Bot 2010-05-14 18:43:44 PDT
Comment on attachment 55994 [details]
added comments per Kenneth's review

Clearing flags on attachment: 55994

Committed r59510: <http://trac.webkit.org/changeset/59510>
Comment 7 WebKit Commit Bot 2010-05-14 18:43:51 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Simon Hausmann 2010-05-16 01:03:15 PDT
Revision r59510 cherry-picked into qtwebkit-2.0 with commit ead6be782dbaa32cf9c33e21b3c32d2f78c4d0a5