Bug 39153 - Canvas's toDataURL() should be case insensitive wrt the mimeType argument
Summary: Canvas's toDataURL() should be case insensitive wrt the mimeType argument
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 39173
Blocks: 35784
  Show dependency tree / graph
 
Reported: 2010-05-15 00:13 PDT by Andreas Kling
Modified: 2010-05-18 22:04 PDT (History)
5 users (show)

See Also:

Attachments
Proposed patch (4.87 KB, patch)
2010-05-15 00:14 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Patch for landing (5.50 KB, patch)
2010-05-15 18:02 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Updated patch with specialized GTK expectations (5.92 KB, patch)
2010-05-16 00:41 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2010-05-15 00:13:06 PDT 
See HTML5 spec 4.8.11:
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#dom-canvas-todataurl

"User agents must convert the provided type to ASCII lowercase before establishing if they support that type and before creating the data: URL."
Comment 1 Andreas Kling 2010-05-15 00:14:57 PDT 
Created attachment 56146 [details]
Proposed patch
Comment 2 Kenneth Rohde Christiansen 2010-05-15 12:08:36 PDT 
Comment on attachment 56146 [details]
Proposed patch

I would suggest linking to the spec in the ChangeLog, at least before landing.
Comment 3 Adam Barth 2010-05-15 18:02:35 PDT 
Created attachment 56168 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2010-05-15 20:15:35 PDT 
Comment on attachment 56168 [details]
Patch for landing

Clearing flags on attachment: 56168

Committed r59565: <http://trac.webkit.org/changeset/59565>
Comment 5 WebKit Commit Bot 2010-05-15 20:15:40 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2010-05-15 20:34:01 PDT 
http://trac.webkit.org/changeset/59565 might have broken GTK Linux 32-bit Release
Comment 7 Eric Seidel (no email) 2010-05-15 21:36:12 PDT 
This broke gtk.  I can't roll it out from my phone, but someone should feel free to. :)  it may just need espectations update. ;)
Comment 9 Adam Barth 2010-05-15 23:51:12 PDT 
Rolling out.
Comment 10 Andreas Kling 2010-05-16 00:41:05 PDT 
Created attachment 56181 [details]
Updated patch with specialized GTK expectations

Apparently GTK doesn't support the image/jpeg mimetype so the test outcome differs slightly.
Comment 11 WebKit Commit Bot 2010-05-16 14:09:03 PDT 
Comment on attachment 56181 [details]
Updated patch with specialized GTK expectations

Clearing flags on attachment: 56181

Committed r59581: <http://trac.webkit.org/changeset/59581>
Comment 12 WebKit Commit Bot 2010-05-16 14:09:10 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 13 Simon Hausmann 2010-05-18 22:02:53 PDT 
Revision r59581 cherry-picked into qtwebkit-2.0 with commit ad27430eb1173d688a5a335edadb1c0d55462732