Bug 39218 - [Qt] Tiled backing store tiles sometimes flicker when exiting a zoom animation
Summary: [Qt] Tiled backing store tiles sometimes flicker when exiting a zoom animation
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P3 Normal
Assignee: Nobody
URL:
Keywords: Qt
: 39154 (view as bug list)
Depends on:
Blocks: 35784
  Show dependency tree / graph
 
Reported: 2010-05-17 07:44 PDT by Antti Koivisto
Modified: 2010-11-12 10:55 PST (History)
2 users (show)

See Also:

Attachments
patch (10.61 KB, patch)
2010-05-17 07:57 PDT, Antti Koivisto 		kenneth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2010-05-17 07:44:11 PDT 
Tiles some times flicker when exiting a zoom animation. This happens as a result of the visible rectangle being momentarily out of sync.
Comment 1 Antti Koivisto 2010-05-17 07:57:03 PDT 
Created attachment 56244 [details]
patch

Instead of updating the visible rect by explicitly setting it, pull it through the client and recompute in the WebKit level.
Comment 2 Kenneth Rohde Christiansen 2010-05-17 08:03:16 PDT 
Comment on attachment 56244 [details]
patch

Looks fine, thought I would like a better name for checkVisibleRectChanged();

Maybe adjustVisibleRect? or something similar
Comment 3 Antti Koivisto 2010-05-17 08:39:02 PDT 
with the suggested rename:

Sending        WebCore/ChangeLog
Sending        WebCore/page/ChromeClient.h
Sending        WebCore/page/Frame.cpp
Sending        WebCore/page/Frame.h
Sending        WebCore/platform/graphics/TiledBackingStore.cpp
Sending        WebCore/platform/graphics/TiledBackingStore.h
Sending        WebCore/platform/graphics/TiledBackingStoreClient.h
Sending        WebKit/qt/Api/qgraphicswebview.cpp
Sending        WebKit/qt/ChangeLog
Sending        WebKit/qt/WebCoreSupport/ChromeClientQt.cpp
Sending        WebKit/qt/WebCoreSupport/ChromeClientQt.h
Transmitting file data ...........
Committed revision 59611.

Sending        WebCore/ChangeLog
Sending        WebCore/platform/qt/QWebPageClient.h
Transmitting file data ..
Committed revision 59612.
Comment 4 Simon Hausmann 2010-05-18 22:16:30 PDT 
Revision r59611 cherry-picked into qtwebkit-2.0 with commit 9c30b2733c9727c5313df46bcf01cb9cdefbd5a1
Comment 5 Simon Hausmann 2010-05-18 22:17:12 PDT 
(In reply to comment #4)
> Revision r59611 cherry-picked into qtwebkit-2.0 with commit 9c30b2733c9727c5313df46bcf01cb9cdefbd5a1

r59612 is also included in the same sha1.
Comment 6 Andreas Kling 2010-11-12 10:55:07 PST 
*** Bug 39154 has been marked as a duplicate of this bug. ***