Bug 39314 - [Qt] Skipping popup focus test for maemo
Summary: [Qt] Skipping popup focus test for maemo
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Luiz Agostini
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2010-05-18 13:30 PDT by Luiz Agostini
Modified: 2011-04-19 05:15 PDT (History)
2 users (show)

See Also:


Attachments
patch 1 (4.01 KB, patch)
2010-05-18 13:55 PDT, Luiz Agostini
no flags Details | Formatted Diff | Diff
patch 2 (4.72 KB, patch)
2010-05-18 14:55 PDT, Luiz Agostini
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Luiz Agostini 2010-05-18 13:30:45 PDT
in tst_qwebframe the popup focus test is based on the usage of a QComboBox by QtWebKit to provide combo popups. As maemo does not use a QComboBox for that the test does not make sense for maemo.
Comment 1 Luiz Agostini 2010-05-18 13:55:47 PDT
Created attachment 56410 [details]
patch 1
Comment 2 Luiz Agostini 2010-05-18 14:55:34 PDT
Created attachment 56415 [details]
patch 2
Comment 3 Kenneth Rohde Christiansen 2010-05-18 14:58:01 PDT
Comment on attachment 56415 [details]
patch 2

LGTM, please block the patch for qtwebkit2.0 branch integration/
Comment 4 WebKit Commit Bot 2010-05-20 06:44:07 PDT
Comment on attachment 56415 [details]
patch 2

Clearing flags on attachment: 56415

Committed r59831: <http://trac.webkit.org/changeset/59831>
Comment 5 WebKit Commit Bot 2010-05-20 06:44:13 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Simon Hausmann 2010-05-20 08:11:53 PDT
Revision r59831 cherry-picked into qtwebkit-2.0 with commit d7f3d44c8e0cecdb945219ec5dfb289bcf9a803f