Bug 41157 - Spatial Navigation: refactor spatial-navigation-utils.js to support testing nested frames deeper than one level
Summary: Spatial Navigation: refactor spatial-navigation-utils.js to support testing n...
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Antonio Gomes
URL:
Keywords:
Depends on:
Blocks: 18662 41160
  Show dependency tree / graph
 
Reported: 2010-06-24 07:12 PDT by Antonio Gomes
Modified: 2011-04-19 05:15 PDT (History)
1 user (show)

See Also:

Attachments
(commit r61819, r=kenneth) patch v1 (28.39 KB, patch)
2010-06-24 07:29 PDT, Antonio Gomes 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Gomes 2010-06-24 07:12:07 PDT 
Currently, it is not possible to test focused elements in {i}frames nested in more than one level deep (see sample below):

<html>
<body>
   <iframe width="50%" height="100px" frameborder="1" src="resources/iframe.html"></iframe><br>
     <body>
       <iframe width='80%' height="70px" frameborder="0" src="data:text/html,
        <body>
          <a id='1' href='#'>a</a>


patch coming ...
Comment 1 Antonio Gomes 2010-06-24 07:29:58 PDT 
Created attachment 59653 [details]
(commit r61819, r=kenneth) patch v1

The output of all spatial navigation changed , but these are string changes only, so this part of the patch can be "ignored".

e.g.

-PASS document.activeElement.getAttribute("id") is "end"
+PASS gFocusedDocument.activeElement.getAttribute("id") is "end"
Comment 2 Antonio Gomes 2010-06-24 22:16:52 PDT 
Comment on attachment 59653 [details]
(commit r61819, r=kenneth) patch v1

Clearing flags on attachment: 59653

Committed r61819: <http://trac.webkit.org/changeset/61819>
Comment 3 Antonio Gomes 2010-07-01 06:15:25 PDT 
@tronical, cherry-picking this one, would make Spatial navigation layouttests in QtWebKit-2.0 branch green.
Comment 4 Simon Hausmann 2010-07-01 12:54:07 PDT 
Revision r61819 cherry-picked into qtwebkit-2.0 with commit fe2f92a1322131a92d23273b84fe672257b46388