Bug 42787 - The transaction callback parameter of db.changeVersion() should be optional
Summary: The transaction callback parameter of db.changeVersion() should be optional
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Dumitru Daniliuc
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-21 14:25 PDT by Dumitru Daniliuc
Modified: 2010-09-24 07:35 PDT (History)
3 users (show)

See Also:

Attachments
patch (8.90 KB, patch)
2010-07-21 15:25 PDT, Dumitru Daniliuc 		dumi: commit-queue-
Details | Formatted Diff | Diff
patch (10.89 KB, patch)
2010-07-21 15:30 PDT, Dumitru Daniliuc 		ojan: review+
dumi: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dumitru Daniliuc 2010-07-21 14:25:45 PDT 
The spec says that the third parameter of db.changeVersion() (the transaction callback) is optional. It is currently mandatory in WebCore.
Comment 1 Dumitru Daniliuc 2010-07-21 15:25:25 PDT 
Created attachment 62239 [details]
patch
Comment 2 Dumitru Daniliuc 2010-07-21 15:30:30 PDT 
Created attachment 62240 [details]
patch

same patch, forgot to make some minor changes to the v8 bindings.
Comment 3 Dumitru Daniliuc 2010-07-22 13:57:27 PDT 
landed: r63910.
Comment 4 Simon Hausmann 2010-09-24 07:34:33 PDT 
<cherry-pick-for-backport: r63910>
Comment 5 Simon Hausmann 2010-09-24 07:35:07 PDT 
Revision r63910 cherry-picked into qtwebkit-2.1 with commit 8e0cd1b <http://gitorious.org/webkit/qtwebkit/commit/8e0cd1b>