Bug 43518 - [Qt][QtTestBrowser] Remove unneeded QAction class members
Summary: [Qt][QtTestBrowser] Remove unneeded QAction class members
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Antonio Gomes
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-08-04 16:15 PDT by Antonio Gomes
Modified: 2010-08-04 17:27 PDT (History)
0 users

See Also:

Attachments
(committed with r64694, r=kenneth) patch (5.36 KB, patch)
2010-08-04 16:38 PDT, Antonio Gomes 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Gomes 2010-08-04 16:15:52 PDT 
LauncherWindow class has two totally unneeded class members: m_flopAnimated and m_flipYAnimated. Also, in initializeView method there are some dead code block trying to connect them at the wrong time, when they have not been instanciated.
Comment 1 Antonio Gomes 2010-08-04 16:38:53 PDT 
Created attachment 63511 [details]
(committed with r64694, r=kenneth) patch

This patch:
    
- removes the two cited class members in favor of local variables in createChrome method;
- removes the dead code block.
Comment 2 Antonio Gomes 2010-08-04 17:26:48 PDT 
Comment on attachment 63511 [details]
(committed with r64694, r=kenneth) patch

Clearing flags on attachment: 63511

Committed r64694: <http://trac.webkit.org/changeset/64694>