Bug 45001 - [Qt] tst_QWebPage::originatingObjectInNetworkRequests() fails on trunk
Summary: [Qt] tst_QWebPage::originatingObjectInNetworkRequests() fails on trunk
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 44675
  Show dependency treegraph
 
Reported: 2010-08-31 16:07 PDT by Benjamin Poulain
Modified: 2010-09-01 14:45 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.54 KB, patch)
2010-08-31 16:11 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2010-08-31 16:07:51 PDT
The auto test tst_QWebPage::originatingObjectInNetworkRequests() fails with the new parser. The test is actually broken due to a bad copy paste ("data:text/html,") so that is an oportunity to fix it.
Comment 1 Benjamin Poulain 2010-08-31 16:11:23 PDT
Created attachment 66131 [details]
Patch

Fix the test, we should not use data encoded URL since we are not setting an URL but setting the substituteData directly.
Comment 2 WebKit Commit Bot 2010-08-31 18:56:05 PDT
Comment on attachment 66131 [details]
Patch

Clearing flags on attachment: 66131

Committed r66565: <http://trac.webkit.org/changeset/66565>
Comment 3 WebKit Commit Bot 2010-08-31 18:56:09 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Ademar Reis 2010-09-01 14:45:04 PDT
Revision r66565 cherry-picked into qtwebkit-2.1 with commit c121913db5cec9acebf477036324051b8b1d3660