Bug 45694 - 'seeking' event should always fire
Summary: 'seeking' event should always fire
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords:
Depends on:
Blocks: 51249
  Show dependency tree / graph
 
Reported: 2010-09-13 11:51 PDT by Eric Carlson
Modified: 2011-01-24 12:17 PST (History)
1 user (show)

See Also:

Attachments
Proposed patch. (6.67 KB, patch)
2010-09-13 12:15 PDT, Eric Carlson 		simon.fraser: review+
Details | Formatted Diff | Diff
Revised patch (6.88 KB, patch)
2010-09-23 09:00 PDT, Eric Carlson 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2010-09-13 11:51:24 PDT 
In r5219 the spec was changed to require the 'seeking' event to always fire.
Comment 1 Eric Carlson 2010-09-13 12:15:55 PDT 
Created attachment 67449 [details]
Proposed patch.
Comment 2 Eric Carlson 2010-09-23 09:00:25 PDT 
Created attachment 68527 [details]
Revised patch
Comment 3 Simon Fraser (smfr) 2010-09-23 11:39:34 PDT 
Comment on attachment 67449 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=67449&action=review

> WebCore/ChangeLog:6
> +        'seeking' event should always fire
> +        https://bugs.webkit.org/show_bug.cgi?id=45694

Is this just a change to the spec that we're following? If so, the changelog should say.

> WebCore/html/HTMLMediaElement.cpp:1099
> +    // 2 - If the element's seeking IDL attribute is true, then another instance of this algorithm is
> +    // already running. Abort that other instance of the algorithm without waiting for the step that
> +    // it is running to complete.

I don't understand how "another instance of the algorithm" can be running on the same element. Can the comment clarify this?
Comment 4 Eric Carlson 2010-09-23 12:38:20 PDT 
http://trac.webkit.org/changeset/68181
Comment 5 Ademar Reis 2011-01-24 12:17:44 PST 
Revision r68181 cherry-picked into qtwebkit-2.2 with commit d7a0127 <http://gitorious.org/webkit/qtwebkit/commit/d7a0127>