Nokia released Qt 4.7.0, but now ~140 layout tests fail when building WebKit trunk with Qt 4.7.0. (Qt buildbots use Qt 4.6.2 on build.webkit.org now.) "x86-32 Linux Qt-4.7.0 Release" buildbot here: http://webkit.sed.hu/buildbot/waterfall Most of them (~120-130) only need a rebaseline, but there are ~10-20 real bug should be fixed. We are going to set Qt buildbots on build.webkit.org to use Qt 4.7.0 after this meta bug fixed.
*** Bug 48633 has been marked as a duplicate of this bug. ***
Created attachment 75024 [details] migrating to Qt 4.7.1 I think it's time to migrating Qt 4.7.1. The proposed patch: - add failing tests to the Skipped list - remove passing tests from the Skipped list - update expected files related to the migration (4.6.3 -> 4.7.1)
Comment on attachment 75024 [details] migrating to Qt 4.7.1 Awesome, go for it :)
Comment on attachment 75024 [details] migrating to Qt 4.7.1 Landed in http://trac.webkit.org/changeset/72896 Leave the bug open until depending bugs are fixed.
Created attachment 86619 [details] proposed patch for QtWebKit-2.1.x branch I merged http://trac.webkit.org/changeset/72896 to QtWebKit-2.1.x branch without Skipped list modifications. ( I had to remove ~10 expected update from the original patch, because they are already updated in the branch.) Laszlo, Andreas, rs=you? to push it to the QtWebKit-2.1.x and 2.1 branches?
rs=me
Cherry-picked into qtwebkit-2.1 branch with commit 3f3d191ac9dca758cdca75b77f0337f4e5b1e37f <http://gitorious.org/webkit/qtwebkit/commit/3f3d191ac9dca758cdca75b77f0337f4e5b1e37f>
Also merged to qtwebkit-2.1.x branch.
Created attachment 86736 [details] proposed patch for QtWebKit-2.1 and 2.1.x branches Merging http://trac.webkit.org/changeset/72896 to QtWebKit-2.1 QtWebKit-2.1.x branches - step 2. - I added tests to the Skipped list, which passed with Qt 4.6, but fail with Qt 4.7.2 . - I removed tests from the Skipped list, which failed with Qt 4.6, but pass now. rs=?
(In reply to comment #9) > Created an attachment (id=86736) [details] > proposed patch for QtWebKit-2.1 and 2.1.x branches > > Merging http://trac.webkit.org/changeset/72896 to QtWebKit-2.1 QtWebKit-2.1.x branches - step 2. > > - I added tests to the Skipped list, which passed with Qt 4.6, but fail with Qt 4.7.2 . > - I removed tests from the Skipped list, which failed with Qt 4.6, but pass now. > > rs=? rs=me, yo!
Cherry-picked into qtwebkit-2.1 branch with commit f3c5fd7b5e2bb27edd8e0afc2b16b69a7514c301 <http://gitorious.org/webkit/qtwebkit/commit/f3c5fd7b5e2bb27edd8e0afc2b16b69a7514c301> And also merged to qtwebkit-2.1.x branch.
Closing this bug as it seems work is completed and we don't support Qt 4.7 anymore anyway :)
(In reply to comment #12) > Closing this bug as it seems work is completed and we don't support Qt 4.7 anymore anyway :) I don't think if it is completed, because bugs on depends on list are still valid with Qt 4.8 and Qt 5.0.
True, those bugs are still open. But they are not necessarily directly related to Qt 4.7 I think.