Bug 46461 - [Qt] New input style for Qt Mobile theme
Summary: [Qt] New input style for Qt Mobile theme
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks: 46349
  Show dependency treegraph
 
Reported: 2010-09-24 06:52 PDT by Ragner Magalhaes
Modified: 2010-10-06 07:08 PDT (History)
6 users (show)

See Also:


Attachments
Adds web style for Maemo6 platform (6.50 KB, patch)
2010-09-24 10:21 PDT, Ragner Magalhaes
no flags Details | Formatted Diff | Diff
Maemo6 input style(patch result) (49.01 KB, image/png)
2010-09-24 10:23 PDT, Ragner Magalhaes
no flags Details
Adjust Maemo5 style to new Qt Mobile style (10.05 KB, patch)
2010-09-25 08:28 PDT, Ragner Magalhaes
no flags Details | Formatted Diff | Diff
Proposed patch 03 (4.90 KB, patch)
2010-09-27 06:59 PDT, Ragner Magalhaes
no flags Details | Formatted Diff | Diff
Screenshot with raster (53.09 KB, image/png)
2010-09-27 13:37 PDT, Ragner Magalhaes
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ragner Magalhaes 2010-09-24 06:52:01 PDT
Web style for Maemo6 platform is missing.
Comment 1 Ragner Magalhaes 2010-09-24 10:21:41 PDT
Created attachment 68703 [details]
Adds web style for Maemo6 platform

This patch just adjusts the input styles for maemo6.
In other patch I will adjust the missing styles for buttons(check, radio), selects, etc.
Comment 2 Ragner Magalhaes 2010-09-24 10:23:45 PDT
Created attachment 68704 [details]
Maemo6 input style(patch result)
Comment 3 Luiz Agostini 2010-09-24 11:24:18 PDT
Maybe we could have just one theme instead of having different ones for each maemo version.

It could be the mobile theme instead of maemo theme.
Comment 4 Diego Gonzalez 2010-09-24 11:33:44 PDT
(In reply to comment #3)
> Maybe we could have just one theme instead of having different ones for each maemo version.
> 
> It could be the mobile theme instead of maemo theme.

You mean, the same css for maemo 5 and 6? Is possible to detect the platform in the css? If so, could be a good way
Comment 5 Luiz Agostini 2010-09-24 11:38:53 PDT
(In reply to comment #4)
> (In reply to comment #3)
> > Maybe we could have just one theme instead of having different ones for each maemo version.
> > 
> > It could be the mobile theme instead of maemo theme.
> 
> You mean, the same css for maemo 5 and 6? Is possible to detect the platform in the css? If so, could be a good way

No. I am talking about having the same appearance in them all. One mobile theme to all devices.
Comment 6 Ragner Magalhaes 2010-09-24 11:40:38 PDT
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > Maybe we could have just one theme instead of having different ones for each maemo version.
> > > 
> > > It could be the mobile theme instead of maemo theme.
> > 
> > You mean, the same css for maemo 5 and 6? Is possible to detect the platform in the css? If so, could be a good way
> 
> No. I am talking about having the same appearance in them all. One mobile theme to all devices.

So,
Does the new style for maemo6 should replace the maemo5's styles?

Because, for example, the input styles are different for each maemo version.
Comment 7 Ragner Magalhaes 2010-09-25 08:28:55 PDT
Created attachment 68825 [details]
Adjust Maemo5 style to new Qt Mobile style
Comment 8 Kenneth Rohde Christiansen 2010-09-25 08:43:03 PDT
Mameo? That seems wrong. Also the changelog doesn't say what it is going at all, which means that this patch will never be r+'ed in its current state.

Did you mean to put it up for review? if so, set the r? flag
Comment 9 Ragner Magalhaes 2010-09-25 09:16:33 PDT
(In reply to comment #8)
> Mameo? That seems wrong. Also the changelog doesn't say what it is going at

Yes, that is wrong ... 

 all, which means that this patch will never be r+'ed in its current state.
> 
> Did you mean to put it up for review? if so, set the r? flag

I didn't put it for review because I just want to get some
comments from INdT team ... and fix some mistake before.
Comment 10 Antonio Gomes 2010-09-25 09:19:50 PDT
Hum... Is symbian going to use it as well? If no, I would just say 'maemo' not 'mobile'?
Comment 11 Ragner Magalhaes 2010-09-25 09:22:47 PDT
(In reply to comment #10)
> Hum... Is symbian going to use it as well? If no, I would just say 'maemo' not 'mobile'?

Hum .. That sounds good for me :), I will check about ...
Comment 12 Kenneth Rohde Christiansen 2010-09-25 09:33:28 PDT
(In reply to comment #10)
> Hum... Is symbian going to use it as well? If no, I would just say 'maemo' not 'mobile'?

It is using it today I believe... If they want something different that can be another task.

Also, it looks like the patch didnt do a proper move, it says Removed and Added, not Moved.
Comment 13 Ragner Magalhaes 2010-09-25 09:55:19 PDT
(In reply to comment #12)
> (In reply to comment #10)
> > Hum... Is symbian going to use it as well? If no, I would just say 'maemo' not 'mobile'?
> 
> It is using it today I believe... If they want something different that can be another task.
> 
> Also, it looks like the patch didnt do a proper move, it says Removed and Added, not Moved.

Humm ... I will use -M option to detect renames in the next "format-patch"
and adjust the ChangeLog
Comment 14 Antonio Gomes 2010-09-27 06:20:24 PDT
QT = QuickTime :-)
Comment 15 Ragner Magalhaes 2010-09-27 06:59:00 PDT
Created attachment 68904 [details]
Proposed patch 03
Comment 16 Diego Gonzalez 2010-09-27 09:09:42 PDT
Comment on attachment 68904 [details]
Proposed patch 03

Clearing flags. Patch landed at r68393
Comment 17 Ragner Magalhaes 2010-09-27 13:37:21 PDT
Created attachment 68950 [details]
 Screenshot with raster
Comment 18 Henry Haverinen 2010-09-30 07:17:55 PDT
Should this be cherry-picked to QtWebKit 2.1?
Comment 19 Luiz Agostini 2010-09-30 07:42:22 PDT
(In reply to comment #18)
> Should this be cherry-picked to QtWebKit 2.1?

Maybe we should wait until the theme is complete. At this point just text input elements are customized. Ragner still working in buttons, checks, radios and combos.
Comment 20 Ademar Reis 2010-10-06 07:05:24 PDT
Revision r68393 cherry-picked into qtwebkit-2.1 with commit fd20b0a <http://gitorious.org/webkit/qtwebkit/commit/fd20b0a>
Comment 21 Ademar Reis 2010-10-06 07:08:25 PDT
I've also cherry-picked r68035 (3d45725), a trivial change which was needed for this fix <http://gitorious.org/webkit/qtwebkit/commit/3d45725>