The test tst_QWebPage::geolocationRequestJS() always fail with a default build because ENABLE(GEOLOCATION) is false. When the API is fixed, the test should be fixed accordingly to succeed for standard build.
Created attachment 69206 [details] Disable the test
Comment on attachment 69206 [details] Disable the test View in context: https://bugs.webkit.org/attachment.cgi?id=69206&action=review > WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:256 > +#if 0 Please don't disable this code. We want whoever alters the permissions API to update the test as well.
one way to know if geolocation is enabled is by checking return value of frame->evaluateJavascript("navigator.geolocation == undefined"). Based on this we can ignore all assert checks.
(In reply to comment #0) > > When the API is fixed, the test should be fixed accordingly to succeed for standard build. @Benjamin I did not get what you mean here? What has to be fixed in API?
Created attachment 69219 [details] Patch
Created attachment 69220 [details] Ooops
(In reply to comment #4) > > When the API is fixed, the test should be fixed accordingly to succeed for standard build. > > @Benjamin I did not get what you mean here? What has to be fixed in API? The API did not go through any API review, see: https://bugs.webkit.org/show_bug.cgi?id=46810 The API does not seem future proof at the moment. When the API will be better, this test should be re-enabled.
Comment on attachment 69220 [details] Ooops Rejecting patch 69220 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'build-and-test', '--no-clean', '--no-update', '--test', '--quiet', '--non-interactive']" exit_code: 2 Last 500 characters of output: s successful. Files=14, Tests=304, 1 wallclock secs ( 0.72 cusr + 0.16 csys = 0.88 CPU) Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Projects/CommitQueue/LayoutTests Testing 21476 test cases. plugins/plugin-initiate-popup-window.html -> failed Exiting early after 1 failures. 17959 tests run. 321.64s total testing time 17958 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 31 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/4153011
Comment on attachment 69220 [details] Ooops Trying cq+ again. This is just a QSKIP, it has not influence on other tests.
Comment on attachment 69220 [details] Ooops Clearing flags on attachment: 69220 Committed r68760: <http://trac.webkit.org/changeset/68760>
All reviewed patches have been landed. Closing bug.
Reopening since this bug is really about fixing the test. The patch disabling is temporary.
Created attachment 76732 [details] re-enable the test API review is finished; GEOLOCATION is enabled in the master bot. Test will fail if GEOLOCATION is not enabled - I think this is the correct expected behavior from the test.
Comment on attachment 76732 [details] re-enable the test Clearing flags on attachment: 76732 Committed r74173: <http://trac.webkit.org/changeset/74173>
http://trac.webkit.org/changeset/74173 might have broken Leopard Intel Debug (Tests)
This test is failing. Did you take into account my comments? "This test is disabled because it can only succeed if ENABLE(GEOLOCATION) is true."
(In reply to comment #17) > This test is failing. Did you take into account my comments? Failing where ? Seems to be passing on the bot - http://build.webkit.org/builders/Qt%20Linux%20Release/builds/26268/steps/API%20tests/logs/stdio
(In reply to comment #18) > (In reply to comment #17) > > This test is failing. Did you take into account my comments? > > Failing where ? Seems to be passing on the bot - http://build.webkit.org/builders/Qt%20Linux%20Release/builds/26268/steps/API%20tests/logs/stdio On my computer at least. :) But my guess is it fails on any build done without mobility.
Created attachment 78466 [details] Patch
Created attachment 78467 [details] Patch
Comment on attachment 78467 [details] Patch Clearing flags on attachment: 78467 Committed r75479: <http://trac.webkit.org/changeset/75479>