Bug 47325 - [Qt] API: ViewportConfiguration => ViewportArguments
Summary: [Qt] API: ViewportConfiguration => ViewportArguments
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: QtWebKit Unassigned
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-10-06 21:46 PDT by Andreas Kling
Modified: 2010-10-12 07:42 PDT (History)
4 users (show)

See Also:

Attachments
Proposed patch (9.40 KB, patch)
2010-10-06 22:13 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2010-10-06 21:46:31 PDT 
Following the rename in WebCore, QWebPage::ViewportConfiguration should be renamed to QWebPage::ViewportArguments, and QWebPage::viewportConfigurationForSize() should be renamed to QWebPage::viewportAttributesForSize()
Comment 1 Andreas Kling 2010-10-06 22:13:28 PDT 
Created attachment 70035 [details]
Proposed patch
Comment 2 WebKit Commit Bot 2010-10-07 12:41:53 PDT 
Comment on attachment 70035 [details]
Proposed patch

Clearing flags on attachment: 70035

Committed r69331: <http://trac.webkit.org/changeset/69331>
Comment 3 WebKit Commit Bot 2010-10-07 12:41:58 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Ademar Reis 2010-10-08 02:59:34 PDT 
Shouldn't WebKit2 API be changed as well (on trunk)?
Comment 5 Kenneth Rohde Christiansen 2010-10-08 04:37:01 PDT 
(In reply to comment #4)
> Shouldn't WebKit2 API be changed as well (on trunk)?

The WebKit2 API will change as soon as we have the WebKit2 C API approved and integrated. This doesn't depend on our public release.
Comment 6 Ademar Reis 2010-10-08 04:43:17 PDT 
Revision r69331 cherry-picked into qtwebkit-2.1 with commit 15761d2 <http://gitorious.org/webkit/qtwebkit/commit/15761d2>
Comment 7 Keith Kyzivat 2010-10-12 07:42:47 PDT 
This breaks Symbian, as the .def files are now again, out of sync, and need to be re-frozen.