Bug 48319 - [Qt] Some unit tests try to use the data:<content-type>,<content> URL syntax with setHtml
Summary: [Qt] Some unit tests try to use the data:<content-type>,<content> URL syntax ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Jocelyn Turcotte
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2010-10-26 06:40 PDT by Jocelyn Turcotte
Modified: 2010-10-26 13:03 PDT (History)
2 users (show)

See Also:


Attachments
Patch (7.28 KB, patch)
2010-10-26 06:49 PDT, Jocelyn Turcotte
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jocelyn Turcotte 2010-10-26 06:40:45 PDT
[Qt] Unit tests: setHtml("data:text/html,...") -> load(QUrl("data:text/html,..."))
Comment 1 Jocelyn Turcotte 2010-10-26 06:49:47 PDT
Created attachment 71871 [details]
Patch
Comment 2 Jocelyn Turcotte 2010-10-26 06:58:58 PDT
This bug causes the tst_QWebElement::frame(), the tst_QGraphicsWebView::crashOnViewlessWebPages() and some tst_QWebPage unit tests to fail.
Comment 3 Andreas Kling 2010-10-26 07:02:16 PDT
Comment on attachment 71871 [details]
Patch

LGTM
Comment 4 WebKit Commit Bot 2010-10-26 12:35:43 PDT
Comment on attachment 71871 [details]
Patch

Clearing flags on attachment: 71871

Committed r70556: <http://trac.webkit.org/changeset/70556>
Comment 5 WebKit Commit Bot 2010-10-26 12:35:47 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Ademar Reis 2010-10-26 13:03:13 PDT
Revision r70556 cherry-picked into qtwebkit-2.1 with commit f5d4208 <http://gitorious.org/webkit/qtwebkit/commit/f5d4208>