Bug 48324 - [Qt] Skipping popup focus test for symbian
Summary: [Qt] Skipping popup focus test for symbian
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC S60 3rd edition
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-26 07:31 PDT by Yi Shen
Modified: 2010-11-03 10:25 PDT (History)
4 users (show)

See Also:

Attachments
skipping popupFocus for symbian (1.43 KB, patch)
2010-10-26 07:45 PDT, Yi Shen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yi Shen 2010-10-26 07:31:57 PDT 
in tst_qwebframe the popup focus test is based on the usage of a QComboBox by QtWebKit to provide combo popups. As symbian does not use a QComboBox for that the test does not make sense for symbian.
Comment 1 Yi Shen 2010-10-26 07:45:11 PDT 
Created attachment 71882 [details]
skipping popupFocus for symbian
Comment 2 Andreas Kling 2010-10-26 07:49:07 PDT 
Comment on attachment 71882 [details]
skipping popupFocus for symbian

LGTM.
Comment 3 WebKit Commit Bot 2010-10-26 12:49:10 PDT 
Comment on attachment 71882 [details]
skipping popupFocus for symbian

Clearing flags on attachment: 71882

Committed r70558: <http://trac.webkit.org/changeset/70558>
Comment 4 WebKit Commit Bot 2010-10-26 12:49:15 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Suresh Voruganti 2010-11-02 10:22:35 PDT 
Pls cherry pick the fix for Qtwebkit 2.1 branch.
Comment 6 Ademar Reis 2010-11-03 10:25:10 PDT 
Revision r70558 cherry-picked into qtwebkit-2.1 with commit 136130c <http://gitorious.org/webkit/qtwebkit/commit/136130c>