Flash plugins should work in windowless mode on QGraphicsWebView. Default mode for Nokia flash plugin will be windowless. Generally, #ifdef introduced by commit r69396 should be removed.
Created attachment 75548 [details] Remove #ifdef OS(SYMBIAN)
Comment on attachment 75548 [details] Remove #ifdef OS(SYMBIAN) Looks good to me, r+. However I'd like to hear from Hui that he is OK committing the change; cq- for now.
The reason to disable the code to force Flash plugin to run in Windowless mode on Symbian was based on the comments from Symbian Flash Player developers that Symbian Flash Player works better in Windowed mode. Simon already commented about the problems with windowed plugin in Qt Graphics View. If running in Windowless mode is no longer a problem for Symbian Flash Player, I don't have any problem with this patch.
Sounds like this should be cq+'d now?
I think so.
Comment on attachment 75548 [details] Remove #ifdef OS(SYMBIAN) cq+. Laszlo
Comment on attachment 75548 [details] Remove #ifdef OS(SYMBIAN) Clearing flags on attachment: 75548 Committed r74057: <http://trac.webkit.org/changeset/74057>
All reviewed patches have been landed. Closing bug.
Revision r74057 cherry-picked into qtwebkit-2.2 with commit cc20929 <http://gitorious.org/webkit/qtwebkit/commit/cc20929>