On r78808 it is easily reproducable: (Using platform mac to get many pixel differences) $ Tools/Scripts/run-webkit-tests --debug --platform mac -p svg/W3C-SVG-1.1-SE/coords-dom-01-f.svg svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg svg/W3C-SVG-1.1-SE/coords-dom-03-f.svg svg/W3C-SVG-1.1-SE/coords-dom-04-f.svg svg/W3C-SVG-1.1-SE/filters-image-03-f.svg svg/W3C-SVG-1.1-SE/paths-dom-02-f.svg During the 5. test ImageDiff hangs: Tools/DumpRenderTree/qt/ImageDiff.cpp:138: if (fwrite(data.constData(), 1, data.length(), stdout)) {} I'm going to debug and fix this bug. It is the first step to run Qt pixel tests. ;)
Created attachment 82816 [details] proposed fix
ImageDiff was written by Ariya and reviewed by Simon: https://bugs.webkit.org/show_bug.cgi?id=27813 ImageDiff is able to compare pairs of images. actualImage and baselineImage should be cleared after all comparison: + actualImage = QImage(); + baselineImage = QImage();
Comment on attachment 82816 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=82816&action=review > Tools/DumpRenderTree/qt/ImageDiff.cpp:146 > + actualImage = QImage(); > + baselineImage = QImage(); This should be below the next } so they get cleared if one of them isNull(), too.
Comment on attachment 82816 [details] proposed fix Superficial review fail, didn't realize this was an FSM. r=me, motherlover :)
The commit-queue encountered the following flaky tests while processing attachment 82816 [details]: media/invalid-media-url-crash.html bug 51138 (author: inferno@chromium.org) The commit-queue is continuing to process your patch.
Comment on attachment 82816 [details] proposed fix Clearing flags on attachment: 82816 Committed r78840: <http://trac.webkit.org/changeset/78840>
All reviewed patches have been landed. Closing bug.
Revision r78840 cherry-picked into qtwebkit-2.1 with commit 3d8aeee68ff7943cc50e4b321b1071195b671d0a <http://gitorious.org/webkit/qtwebkit/commit/3d8aeee68ff7943cc50e4b321b1071195b671d0a>
Also merged into qtwebkit-2.1.x