Bug 54809 - [EFL] Frame flattening option for EWebLauncher
Summary: [EFL] Frame flattening option for EWebLauncher
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 44253
Blocks:
  Show dependency tree / graph
 
Reported: 2011-02-19 10:12 PST by Lukasz Slachciak
Modified: 2011-02-25 23:55 PST (History)
6 users (show)

See Also:

Attachments
frame flattening for EWebLauncher (5.52 KB, patch)
2011-02-19 10:17 PST, Lukasz Slachciak 		no flags Details | Formatted Diff | Diff
frame flattening for EWebLauncher (5.42 KB, patch)
2011-02-21 15:17 PST, Lukasz Slachciak 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lukasz Slachciak 2011-02-19 10:12:39 PST 
Attached patch adds -f option for EWebLauncher to create view with frame flattening enabled/disabled
Comment 1 Lukasz Slachciak 2011-02-19 10:17:34 PST 
Created attachment 83078 [details]
frame flattening for EWebLauncher
Comment 2 Gyuyoung Kim 2011-02-20 18:40:41 PST 
Comment on attachment 83078 [details]
frame flattening for EWebLauncher

View in context: https://bugs.webkit.org/attachment.cgi?id=83078&action=review

Looks good to me. :-)

> Tools/ChangeLog:6
> +        https://webkit.org/b/54809

Bug url is strange. Please fix it with https://bugs.webkit.org/show_bug.cgi?id=54809
Comment 3 Gyuyoung Kim 2011-02-20 18:42:52 PST 
Comment on attachment 83078 [details]
frame flattening for EWebLauncher

View in context: https://bugs.webkit.org/attachment.cgi?id=83078&action=review

> Tools/ChangeLog:7
> +

Please add summary of this patch.
Comment 4 Lukasz Slachciak 2011-02-21 15:17:54 PST 
Created attachment 83224 [details]
frame flattening for EWebLauncher
Comment 5 Lukasz Slachciak 2011-02-21 15:19:54 PST 
Hello Gyuyoung. I extended url in ChangeLog and added short note.
Comment 6 Lukasz Slachciak 2011-02-24 22:33:37 PST 
So looks like we are waiting for reviewer now :)
Comment 7 Gyuyoung Kim 2011-02-25 00:08:53 PST 
(In reply to comment #6)
> So looks like we are waiting for reviewer now :)

Yes, It looks reviewers are busy.  I think Antonio will review this patch. :-)
Comment 8 Gyuyoung Kim 2011-02-25 00:12:57 PST 
Comment on attachment 83224 [details]
frame flattening for EWebLauncher

Hello kenneth, Thank you for your review :-)
Comment 9 WebKit Commit Bot 2011-02-25 23:55:23 PST 
Comment on attachment 83224 [details]
frame flattening for EWebLauncher

Clearing flags on attachment: 83224

Committed r79761: <http://trac.webkit.org/changeset/79761>
Comment 10 WebKit Commit Bot 2011-02-25 23:55:29 PST 
All reviewed patches have been landed.  Closing bug.