RESOLVED FIXED 55623
Make the runJavaScriptInMainFrame callback send a WKSerializedScriptValueRef
https://bugs.webkit.org/show_bug.cgi?id=55623
Summary Make the runJavaScriptInMainFrame callback send a WKSerializedScriptValueRef
Timothy Hatcher
Reported Wednesday, March 2, 2011 11:13:00 PM UTC
Make the runJavaScriptInMainFrame callback send a WKSerializedScriptValueRef instead of a WKStringRef.
Attachments
Proposed Change (14.22 KB, patch)
2011-03-02 15:20 PST, Timothy Hatcher
darin: review+
timothy: commit-queue-
Proposed Tools Change (5.69 KB, patch)
2011-03-03 16:43 PST, Timothy Hatcher
darin: review+
timothy: commit-queue-
Timothy Hatcher
Comment 1 Wednesday, March 2, 2011 11:20:14 PM UTC
Created attachment 84476 [details] Proposed Change
Timothy Hatcher
Comment 2 Thursday, March 3, 2011 1:23:33 AM UTC
Landed in r80188.
Timothy Hatcher
Comment 3 Friday, March 4, 2011 12:43:28 AM UTC
Created attachment 84655 [details] Proposed Tools Change
Timothy Hatcher
Comment 4 Friday, March 4, 2011 12:46:31 AM UTC
Reopend to track fixing the tests and relanding after a roll out.
Darin Adler
Comment 5 Friday, March 4, 2011 12:46:49 AM UTC
Comment on attachment 84655 [details] Proposed Tools Change Looks fine.
Build Bot
Comment 6 Friday, March 4, 2011 4:53:06 AM UTC
Timothy Hatcher
Comment 7 Friday, March 4, 2011 5:25:08 AM UTC
Adam, any tips why this fails to build on Windows?
Timothy Hatcher
Comment 8 Friday, March 4, 2011 4:39:41 PM UTC
I forgot the tools patch didn't have the main changes to WebKit2, so it wouldn't build.
Timothy Hatcher
Comment 9 Friday, March 4, 2011 5:52:11 PM UTC
Note You need to log in before you can comment on or make changes to this bug.