qt/tests/qdeclarativewebview/tst_qdeclarativewebview fails on symbian. Log file is attached.
Created attachment 91156 [details] Patch qml files cannot be loaded on the symbian due to the differences in capabilities between qmlwebkitplugin.dll and Qtwebkit.dll. It is giving a platsec error that Qtwebkit.dll has "DRM AllFiles" capabilities missing. Changing declarative.pro to match the capabilities set in QtWebKit.pro. Adding WriteDeviceData capability in tests.pri.
Attachment 91156 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/qt/ChangeLog', u'Source/WebK..." exit_code: 1 Source/WebKit/qt/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Source/WebKit/qt/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Source/WebKit/qt/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Source/WebKit/qt/ChangeLog:11: Line contains tab character. [whitespace/tab] [5] Source/WebKit/qt/ChangeLog:12: Line contains tab character. [whitespace/tab] [5] Total errors found: 5 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 91156 [details] Patch I _think_ this is probably the correct solution, but let's see what Laszlo or Janne say. I'm r-'ing this one due to the style issues reported (no tabs in the ChangeLog).
Created attachment 91277 [details] Patch Resubmitting the patch. Changed the tabs to spaces in ChangeLog.
Patch looks ok for developer signed DLLs. Though, not entirely sure if this kind of patching is needed. Qt DLLs use all - tcb for production as they should and in case of self/developer signing patch_capabilities.pl is used. What device data we are writing? Could it be that the directories are wrong and we end up writing in dir that we shouldn't be ?
Comment on attachment 91277 [details] Patch rs=me.
Comment on attachment 91277 [details] Patch Leaving the cq+ off, to give real nokia contributors more time to comment.
Any symbian dev has comment regarding what Janne said?
Created attachment 96252 [details] Slightly cleaned up patch. Changes from Aravind's last patch: - improved Changelog comment - similar to QtWebKit.pro, uses the CONFIG(production) flag for the QML plugin as well as platform plugin - removes use of TARGET.VID from Yi Shen's platform plugin .pro file. (we don't use it in any other WebKit DLL)
Comment on attachment 91277 [details] Patch I plan to advance https://bug-59481-attachments.webkit.org/attachment.cgi?id=96252 instead, so clearing r+.
Comment on attachment 96252 [details] Slightly cleaned up patch. Looks great, thanks !
Comment on attachment 96252 [details] Slightly cleaned up patch. Clearing flags on attachment: 96252 Committed r88253: <http://trac.webkit.org/changeset/88253>
All reviewed patches have been landed. Closing bug.
Revision r88253 cherry-picked into qtwebkit-2.2 with commit 7b8defb <http://gitorious.org/webkit/qtwebkit/commit/7b8defb>