ARM debug builds that include ARMAssembler.h fail to find symbol m_formatter: ../../../webkit/Source/JavaScriptCore/assembler/ARMAssembler.h:686:41: error: 'm_formatter' was not declared in this scope m_formatter isn't declared anywhere visible to ARMAssembler.h I do see that this was originally declared in ARMv7Assembler.h, with a similar debugOffset() method using it.. This has been since replaced with a call to m_buffer.debugOffset(). I'm not too familiar with this code, so I'm not sure what exactly the right thing to do is.
Created attachment 93243 [details] Patch
Patch builds without error -- and looks like the right thing to do when comparing to what ARMv7Assembler.h.
Comment on attachment 93243 [details] Patch LGTM, r=me
Comment on attachment 93243 [details] Patch Clearing flags on attachment: 93243 Committed r86316: <http://trac.webkit.org/changeset/86316>
All reviewed patches have been landed. Closing bug.
http://trac.webkit.org/changeset/86316 might have broken Leopard Intel Debug (Tests) The following tests are not passing: editing/deleting/delete-ligature-001.html editing/deleting/delete-ligature-002.html editing/deleting/delete-ligature-003.html platform/mac/editing/input/devanagari-ligature.html
Revision r86316 cherry-picked into qtwebkit-2.2 with commit b718e0e <http://gitorious.org/webkit/qtwebkit/commit/b718e0e>