Bug 60984 - [Qt] Fix tst_QWebFrame::getSetStaticProperty() autotest
Summary: [Qt] Fix tst_QWebFrame::getSetStaticProperty() autotest
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Caio Marcelo de Oliveira Filho
URL:
Keywords:
Depends on:
Blocks: 38654
  Show dependency treegraph
 
Reported: 2011-05-17 13:48 PDT by Caio Marcelo de Oliveira Filho
Modified: 2011-05-19 13:35 PDT (History)
2 users (show)

See Also:


Attachments
Patch (4.63 KB, patch)
2011-05-17 13:57 PDT, Caio Marcelo de Oliveira Filho
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Caio Marcelo de Oliveira Filho 2011-05-17 13:48:02 PDT
[Qt] Fix tst_QWebFrame::getSetStaticProperty() autotest
Comment 1 Caio Marcelo de Oliveira Filho 2011-05-17 13:57:51 PDT
Created attachment 93813 [details]
Patch
Comment 2 Andreas Kling 2011-05-17 17:06:22 PDT
Comment on attachment 93813 [details]
Patch

r=me, though I wonder about other potential cases where we'd end up with an exception on the ExecState.
Comment 3 Caio Marcelo de Oliveira Filho 2011-05-18 06:51:11 PDT
(In reply to comment #2)
> (From update of attachment 93813 [details])
> r=me, though I wonder about other potential cases where we'd end up with an exception on the ExecState.

There are other potential cases, like value.toString. However, the conversion function is huge and I want clean it up before treating the other cases.

I'm landing this since it fix the concrete reproducible (and important) case we have -- converting 'document' to 'QVariantMap'. We can improve the exception "cleaning" later.
Comment 4 WebKit Commit Bot 2011-05-18 07:13:08 PDT
Comment on attachment 93813 [details]
Patch

Clearing flags on attachment: 93813

Committed r86758: <http://trac.webkit.org/changeset/86758>
Comment 5 WebKit Commit Bot 2011-05-18 07:13:13 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Ademar Reis 2011-05-19 13:35:58 PDT
Revision r86758 cherry-picked into qtwebkit-2.2 with commit cace979 <http://gitorious.org/webkit/qtwebkit/commit/cace979>