Bug 61045 - [Qt] Fix tst_QWebPage::testOptionalJSObjects() autotest
Summary: [Qt] Fix tst_QWebPage::testOptionalJSObjects() autotest
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 38654
  Show dependency treegraph
 
Reported: 2011-05-18 05:15 PDT by Csaba Osztrogonác
Modified: 2012-11-14 06:10 PST (History)
5 users (show)

See Also:


Attachments
mark failing test cases as expected fail (476 bytes, patch)
2011-05-20 06:35 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff
mark failing test cases as expected fail (1.66 KB, patch)
2011-05-20 06:37 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2011-05-18 05:15:03 PDT
FAIL!  : tst_QWebPage::testOptionalJSObjects() Compared values are not the same
   Actual (testFlag(webPage2, QWebSettings::LocalStorageEnabled, "localStorage", true)): 0
   Expected (true): 1
   Loc: [/ramdisk/qt-linux-release/build/Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(2295)]
Comment 1 Csaba Osztrogonác 2011-05-20 06:35:44 PDT
Created attachment 94210 [details]
mark failing test cases as expected fail
Comment 2 Csaba Osztrogonác 2011-05-20 06:36:15 PDT
Comment on attachment 94210 [details]
mark failing test cases as expected fail

wrong patch
Comment 3 Csaba Osztrogonác 2011-05-20 06:37:08 PDT
Created attachment 94211 [details]
mark failing test cases as expected fail
Comment 4 WebKit Review Bot 2011-05-20 06:39:52 PDT
Attachment 94211 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/qt/ChangeLog', u'Source/WebK..." exit_code: 1

Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:2342:  Missing space after ,  [whitespace/comma] [3]
Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp:2345:  Missing space after ,  [whitespace/comma] [3]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Csaba Osztrogonác 2011-05-20 06:46:51 PDT
Comment on attachment 94211 [details]
mark failing test cases as expected fail

cq-, I'll fix the style issue before landing.
Comment 6 Csaba Osztrogonác 2011-05-20 07:26:49 PDT
Comment on attachment 94211 [details]
mark failing test cases as expected fail

Landed in http://trac.webkit.org/changeset/86951
Comment 7 Rafael Brandao 2011-05-20 10:15:43 PDT
I've tried to solve this here: https://bugs.webkit.org/show_bug.cgi?id=58847. There's a patch waiting for review there by the way.
Comment 8 Ademar Reis 2011-06-01 12:32:35 PDT
Revision r86951 cherry-picked into qtwebkit-2.2 with commit e34811a <http://gitorious.org/webkit/qtwebkit/commit/e34811a>
Comment 9 Ademar Reis 2011-06-08 11:03:29 PDT
(In reply to comment #7)
> I've tried to solve this here: https://bugs.webkit.org/show_bug.cgi?id=58847. There's a patch waiting for review there by the way.

Even with your patch, the two failures are still there, but they're different than the one originally reported on this bug. The ones currently failing are:

FAIL!  : tst_QWebPage::testOptionalJSObjects() Compared values are not the same
   Actual (testFlag(webPage1, QWebSettings::OfflineWebApplicationCacheEnabled, "applicationCache", false)): 1
   Expected (false): 0
   Loc: [/opt/projects/webkit/qtwebkit-2.2/Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(2335)]

and if we continue (via XFAIL):

FAIL!  : tst_QWebPage::testOptionalJSObjects() Compared values are not the same
   Actual (testFlag(webPage1, QWebSettings::OfflineWebApplicationCacheEnabled, "applicationCache", false)): 1
   Expected (false): 0
   Loc: [/opt/projects/webkit/qtwebkit-2.2/Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(2338)]
Comment 10 Rafael Brandao 2011-06-13 18:09:22 PDT
They were failing before: https://bugs.webkit.org/show_bug.cgi?id=29867
Perhaps we should reopen that bug, and close this one as it is a duplicate.
Comment 11 Csaba Osztrogonác 2012-11-14 06:10:39 PST
Tests aren't marked as failures now, so they work fine.