Bug 61202 - [Qt] fast/canvas/webgl/gl-object-get-calls.html crash for Qt based webkit
Summary: [Qt] fast/canvas/webgl/gl-object-get-calls.html crash for Qt based webkit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-20 11:20 PDT by Idrees
Modified: 2011-05-27 11:36 PDT (History)
2 users (show)

See Also:

Attachments
Test case (12.62 KB, text/html)
2011-05-20 11:21 PDT, Idrees 		no flags Details
Patch for the fix. (1.61 KB, patch)
2011-05-20 11:33 PDT, Idrees 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Idrees 2011-05-20 11:20:29 PDT 
fast/canvas/webgl/gl-object-get-calls.html crashes for on qt webkit.

It seems like a unintentional left out from the code.
Comment 1 Idrees 2011-05-20 11:21:17 PDT 
Created attachment 94245 [details]
Test case
Comment 2 Idrees 2011-05-20 11:33:07 PDT 
Created attachment 94249 [details]
Patch for the fix.

getAttachedShaders should be called on GraphicsContext3DInternal instance. I think it was left by mistake. I have added it.
Comment 3 Andreas Kling 2011-05-22 23:00:20 PDT 
Comment on attachment 94249 [details]
Patch for the fix.

Infinite recursion eh? Nice catch. r=me
Comment 4 WebKit Commit Bot 2011-05-23 01:07:15 PDT 
Comment on attachment 94249 [details]
Patch for the fix.

Clearing flags on attachment: 94249

Committed r87059: <http://trac.webkit.org/changeset/87059>
Comment 5 WebKit Commit Bot 2011-05-23 01:07:20 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Ademar Reis 2011-05-27 11:36:06 PDT 
Revision r87059 cherry-picked into qtwebkit-2.2 with commit d14495f <http://gitorious.org/webkit/qtwebkit/commit/d14495f>