Bug 61203 - Horrendous bug in callOnMainThreadAndWait
Summary: Horrendous bug in callOnMainThreadAndWait
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-05-20 11:27 PDT by Brady Eidson
Modified: 2011-06-18 11:55 PDT (History)
4 users (show)

See Also:

Attachments
Patch v1 - Acquire the mutex before signaling (1.46 KB, patch)
2011-05-20 11:30 PDT, Brady Eidson 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2011-05-20 11:27:03 PDT 
Horrendous bug in callOnMainThreadAndWait

When the main thread is done with the invocation and decides to signal the waiting thread, it doesn't reacquire the mutex first.  Ouch!

In radar as <rdar://problem/9472883>
Comment 1 Brady Eidson 2011-05-20 11:30:14 PDT 
Created attachment 94247 [details]
Patch v1 - Acquire the mutex before signaling
Comment 2 Brady Eidson 2011-05-20 11:46:28 PDT 
Landed in r86972
Comment 3 Ademar Reis 2011-05-23 07:47:31 PDT 
Revision r86972 cherry-picked into qtwebkit-2.2 with commit 1aba524 <http://gitorious.org/webkit/qtwebkit/commit/1aba524>