[Qt] Remove Phonon MediaPlayer from the tree.
Created attachment 98718 [details] Patch
Not that object to removing things, but I am curious why? Is Phonon dead?
(In reply to comment #2) > Not that object to removing things, but I am curious why? Is Phonon dead? Phonon is deprecated within Qt (but still lives a life on its own as part of the KDE project). It also never worked properly for QtWebKit and noone is maintaining the current code. Our current path is using GStreamer directly on Linux, Quicktime on Mac (and Windows if available). For other cases we will be using QtMultimedia. This provides a better experience for our users and GStreamer is already the backend we are using on the Nokia N9.
Comment on attachment 98718 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98718&action=review > Source/WebKit/qt/docs/qtwebkit.qdocconf:167 > + K_DECLARE_PRIVATE K_? Sounds like some KDE thing, not related to Phonon?
(In reply to comment #4) > (From update of attachment 98718 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=98718&action=review > > > Source/WebKit/qt/docs/qtwebkit.qdocconf:167 > > + K_DECLARE_PRIVATE > > K_? Sounds like some KDE thing, not related to Phonon? May be, I'll remove it then.
(In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 98718 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=98718&action=review > > > > > Source/WebKit/qt/docs/qtwebkit.qdocconf:167 > > > + K_DECLARE_PRIVATE > > > > K_? Sounds like some KDE thing, not related to Phonon? > > May be, I'll remove it then. And will land it manually then, thanks for the review.
Created attachment 98742 [details] Patch for landing
The commit-queue encountered the following flaky tests while processing attachment 98742 [details]: http/tests/local/fileapi/send-dragged-file.html bug 62791 (author: jianli@chromium.org) The commit-queue is continuing to process your patch.
Comment on attachment 98742 [details] Patch for landing Clearing flags on attachment: 98742 Committed r89832: <http://trac.webkit.org/changeset/89832>
All reviewed patches have been landed. Closing bug.
Revision r89832 cherry-picked into qtwebkit-2.2 with commit 312ffd4 <http://gitorious.org/webkit/qtwebkit/commit/312ffd4>