Bug 68435 - WKViews are always inactive when used in NSPopover
Summary: WKViews are always inactive when used in NSPopover
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.7
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-20 06:21 PDT by Timothy Hatcher
Modified: 2011-11-10 13:34 PST (History)
3 users (show)

See Also:

Attachments
Proposed Change (2.93 KB, patch)
2011-09-20 06:22 PDT, Timothy Hatcher 		sullivan: review+
timothy: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2011-09-20 06:21:22 PDT 
Suggested by Darin's comment in bug 68402, I think WKView suffers from a similar issue. I need to make a sample app to verify, but based on code inspection I think WKViews will always be inactive in NSPopovers.
Comment 1 Timothy Hatcher 2011-09-20 06:22:56 PDT 
Created attachment 107995 [details]
Proposed Change

I think this is all WKView needs. I still need to test this.
Comment 2 John Sullivan 2011-09-20 07:22:44 PDT 
Comment on attachment 107995 [details]
Proposed Change

Approval conditional on whether your testing shows that this actually addresses the problem, of course.
Comment 3 Jeff Miller 2011-11-10 13:23:48 PST 
I am using a WKView in an NSPopover, and I can confirm this patch works.
Comment 4 Timothy Hatcher 2011-11-10 13:34:38 PST 
Committed r99894