Bug 72186 - Web Inspector: don't remove InspectorBackendStub.js in Release builds
Summary: Web Inspector: don't remove InspectorBackendStub.js in Release builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-11 14:44 PST by Timothy Hatcher
Modified: 2011-11-11 15:19 PST (History)
3 users (show)

See Also:

Attachments
Proposed Change (6.26 KB, patch)
2011-11-11 14:46 PST, Timothy Hatcher 		timothy: commit-queue-
Details | Formatted Diff | Diff
Proposed Change (round 2) (6.28 KB, patch)
2011-11-11 14:59 PST, Timothy Hatcher 		joepeck: review+
timothy: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2011-11-11 14:44:28 PST 
All the *.js files are combined in Release builds. We should keep InspectorBackendStub.js around so it can be used by other front-ends.
Comment 1 Timothy Hatcher 2011-11-11 14:46:25 PST 
Created attachment 114774 [details]
Proposed Change
Comment 2 Timothy Hatcher 2011-11-11 14:59:09 PST 
Created attachment 114779 [details]
Proposed Change (round 2)
Comment 3 Joseph Pecoraro 2011-11-11 15:09:18 PST 
Comment on attachment 114779 [details]
Proposed Change (round 2)

In the first build phase, instead of the `find -not -name InspectorBackendStub`
it would be clearer to me to just:

    rm *.js
    cp "${DERIVED_FILE_DIR}/WebCore/InspectorBackendStub.js" .

But this approach does create some file churn.

r=me, Either way this looks good.
Comment 4 Timothy Hatcher 2011-11-11 15:19:27 PST 
Committed r100035