Bug 76769 - Web Inspector: Webkit2: attached Inspector height is not remembered
Summary: Web Inspector: Webkit2: attached Inspector height is not remembered
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-20 22:11 PST by Timothy Hatcher
Modified: 2012-01-22 06:06 PST (History)
10 users (show)

See Also:


Attachments
Proposed Change (4.75 KB, patch)
2012-01-21 00:20 PST, Timothy Hatcher
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2012-01-20 22:11:43 PST
The attached height of the Web Inspector is not rememebered between sessions in WebKit2.
Comment 1 Timothy Hatcher 2012-01-21 00:20:47 PST
Created attachment 123437 [details]
Proposed Change
Comment 2 mitz 2012-01-21 00:24:43 PST
Comment on attachment 123437 [details]
Proposed Change

View in context: https://bugs.webkit.org/attachment.cgi?id=123437&action=review

> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:214
> +    [m_inspectorView.get() setFrame:NSMakeRect(NSMinX(inspectedViewFrame), 0.0, NSWidth(inspectedViewFrame), inspectorPageGroup()->preferences()->inspectorAttachedHeight())];

Please change “0.0” to “0”.
Comment 3 Timothy Hatcher 2012-01-22 06:06:17 PST
Commited in r105571