The fonts listed on Kickstarter are never used and are never downloaded. The same happens if you disable images and open the inspector, since we return a set of CachedResources that never loaded. I have a patch.
Created attachment 126704 [details] Proposed Change
Note: the fonts and images don't show up if you load the page with the Inspector open.
Comment on attachment 126704 [details] Proposed Change View in context: https://bugs.webkit.org/attachment.cgi?id=126704&action=review > Source/WebCore/inspector/InspectorPageAgent.cpp:767 > + continue; I think we can test this one.
(In reply to comment #3) > (From update of attachment 126704 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=126704&action=review > > > Source/WebCore/inspector/InspectorPageAgent.cpp:767 > > + continue; > > I think we can test this one. Can you point me to a similar test?
Created attachment 126978 [details] Proposed Change
Attachment 126978 [details] did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9 Updating OpenSource First, rewinding head to replay your work on top of it... Applying: [Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets Using index info to reconstruct a base tree... <stdin>:1578: trailing whitespace. <stdin>:1647: trailing whitespace. <stdin>:1657: trailing whitespace. <stdin>:1672: trailing whitespace. return 0; <stdin>:1674: trailing whitespace. warning: squelched 7 whitespace errors warning: 12 lines add whitespace errors. Falling back to patching base and 3-way merge... warning: too many files (created: 168776 deleted: 3), skipping inexact rename detection Auto-merging LayoutTests/ChangeLog CONFLICT (content): Merge conflict in LayoutTests/ChangeLog Auto-merging Source/WebCore/ChangeLog CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Auto-merging Source/WebKit2/ChangeLog CONFLICT (content): Merge conflict in Source/WebKit2/ChangeLog Auto-merging Tools/ChangeLog CONFLICT (content): Merge conflict in Tools/ChangeLog Failed to merge in the changes. Patch failed at 0001 [Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 126978 [details] Proposed Change View in context: https://bugs.webkit.org/attachment.cgi?id=126978&action=review > LayoutTests/inspector/protocol/page-agent-expected.txt:-80 > - type : "Font" I think this change is worth a real test + original protocol test is worth a valid font. Otherwise two bugs will give us the same result.
(In reply to comment #7) > (From update of attachment 126978 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=126978&action=review > > > LayoutTests/inspector/protocol/page-agent-expected.txt:-80 > > - type : "Font" > > I think this change is worth a real test + original protocol test is worth a valid font. Otherwise two bugs will give us the same result. This uses real fonts. The original test has 2 fonts. With this change only 1 is correctly shown. I don't see the benefit of having another test.
Comment on attachment 126978 [details] Proposed Change View in context: https://bugs.webkit.org/attachment.cgi?id=126978&action=review > LayoutTests/ChangeLog:10 > + * inspector/protocol/page-agent-expected.txt: Updated. It would be nice to state a little more clearly here what is being updated about the test, because it is a bit confusing from the diff. The fact that there is another font shown in the results that was loaded would be good to mention. > Source/WebCore/inspector/InspectorPageAgent.cpp:412 > result.append(it->second.get()); This should just use cachedResource.
Fixed in r107715.