Bug 86173 - Web Inspector: [JSC] instrument timer function calls
Summary: Web Inspector: [JSC] instrument timer function calls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-05-10 21:27 PDT by Timothy Hatcher
Modified: 2012-06-08 08:50 PDT (History)
14 users (show)

See Also:

Attachments
Proposed Change (9.30 KB, patch)
2012-05-10 21:33 PDT, Timothy Hatcher 		yurys: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-03 (537.53 KB, application/zip)
2012-05-11 01:43 PDT, WebKit Review Bot 		no flags Details
Proposed Change (Updated Test Results) (15.69 KB, patch)
2012-05-11 09:48 PDT, Timothy Hatcher 		pfeldman: review+
timothy: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2012-05-10 21:27:04 PDT 
ScheduledAction::executeFunctionInContext does not instrument the function call, so timer's don't show the url/line number in the Timeline.
Comment 1 Timothy Hatcher 2012-05-10 21:27:20 PDT 
<rdar://problem/11427463>
Comment 2 Timothy Hatcher 2012-05-10 21:33:08 PDT 
Created attachment 141322 [details]
Proposed Change
Comment 3 WebKit Review Bot 2012-05-11 01:43:09 PDT 
Comment on attachment 141322 [details]
Proposed Change

Attachment 141322 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12671283

New failing tests:
inspector/timeline/timeline-script-tag-1.html
inspector/timeline/timeline-timer.html
inspector/timeline/timeline-script-tag-2.html
inspector/timeline/timeline-injected-script-eval.html
Comment 4 WebKit Review Bot 2012-05-11 01:43:15 PDT 
Created attachment 141354 [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 5 Timothy Hatcher 2012-05-11 09:48:41 PDT 
Created attachment 141436 [details]
Proposed Change (Updated Test Results)
Comment 6 Konrad Piascik 2012-06-08 08:50:30 PDT 
This has laneded with http://trac.webkit.org/changeset/116821